Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style improvement: Thank you page #170

Closed

Conversation

theflucs
Copy link

@theflucs theflucs commented Sep 7, 2021

Addressing closed issue #160 and open issue #1
Starting off from the awesome contribute of @arvind-1, I made some minor style adjustments.
I found the 3 columns at the bottom a bit confusing to read. But this is just my personal idea, so feel free to drop this pull request if you don't agree.
Cheers

@vercel
Copy link

vercel bot commented Sep 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/margaritahumanitarian/helpafamily/74CcvTuXRsqc3RSGw7EUgCBiZSQc
✅ Preview: https://helpafamily-git-fork-theflucs-impr-4f409d-margaritahumanitarian.vercel.app

@theflucs theflucs changed the title Style: Thank you page Style improvement: Thank you page Sep 7, 2021
@theflucs
Copy link
Author

theflucs commented Sep 7, 2021

Also,
should we allow users to easily visit again the website if they want to?
We can keep the navbar at the top of the page or just add a button linking to the home page.
Just a thought.

@audreyfeldroy
Copy link
Member

Thanks for the PR @theflucs and for your thoughtful comment for @arvind-1, who's also new to the project. That was his first merged PR 🎉

My idea about the 3 columns is that it's a good starting point for adding more functionality. I'm thinking we can move the top single column to the left, then provide a box with a receipt preview filling the right 2 columns. #135 shows an example of what a receipt preview might look like.

Would you like to experiment with that @theflucs, either as part of this PR or in a new one? To limit scope, use fake mockup data for the layout.

@theflucs
Copy link
Author

theflucs commented Sep 8, 2021

@audreyfeldroy Sure I can work on it, but I'm not sure I understood your idea.
Do you mean something like this?

Screenshot 2021-09-08 at 14 19 00

@RedFox0x20 RedFox0x20 marked this pull request as draft September 9, 2021 11:57
@RedFox0x20
Copy link
Collaborator

I have marked this as a draft while the page is still in discussion.

@audreyfeldroy
Copy link
Member

Oh, I really like that @theflucs! Yes, I think that would be awesome. Feel free to experiment: it's okay to deviate from your proposal if you think the columns look better a different way.

@theflucs
Copy link
Author

theflucs commented Sep 22, 2021

Hi @audreyfeldroy, please have a look at these changes.
I finally didn't go for the 3 columns layout, it looked too overfull to me.

@theflucs
Copy link
Author

Sorry, I actually don't know if it's ready for review now 😅

components/ReceiptPreview.js Outdated Show resolved Hide resolved
components/ReceiptPreview.js Outdated Show resolved Hide resolved
components/ReceiptPreview.js Show resolved Hide resolved
components/ReceiptPreview.js Outdated Show resolved Hide resolved
components/ReceiptPreview.js Outdated Show resolved Hide resolved
@theflucs
Copy link
Author

theflucs commented Sep 23, 2021

I am still not convinced about the overall layout of this page though.
I think we can remove the 3 last sections (About Our Donation Software, Improve our Donation Software, Reach Out to Us) from this page and place them in the footer.
Their informations are not strictly related to this one thank you page, they concern the whole project. It makes more sense to have them in the footer, and use it as a place for users to find these extra informations, and maybe more in the future, from anywhere.
In this way we make this page lighter and more focus on its purpose and give the footer a 'bolder' role in the website.
What do you guys think about it?

@arvind-1
Copy link
Contributor

I am still not convinced about the overall layout of this page though.
I think we can remove the 3 last sections (About Our Donation Software, Improve our Donation Software, Reach Out to Us) from this page and place them in the footer.
Their informations are not strictly related to this one thank you page, they concern the whole project. It makes more sense to have them in the footer, and use it as a place for users to find these extra informations, and maybe more in the future, from anywhere.
In this way we make this page lighter and more focus on its purpose and give the footer a 'bolder' role in the website.
What do you guys think about it?

Yes, agree about this, but in some way we need to add a contribution dialog that would be exclusive for only a few among several donors.

@theflucs
Copy link
Author

Finally...! Thank you @marekrozmus!
I should now be fine with formatting, I disabled Prettier - Code formatter and installed Prettier - ESLint, also inside the dev container. Thanks again x

@audreyfeldroy
Copy link
Member

Hi @theflucs thanks so much for all your work on this! To address your comment:

I think we can remove the 3 last sections (About Our Donation Software, Improve our Donation Software, Reach Out to Us) from this page and place them in the footer.

Yes, I think this would improve the page a lot, and I see how it would be useful to have those sections throughout the site.

To address @arvind-1's comment:

Yes, agree about this, but in some way we need to add a contribution dialog that would be exclusive for only a few among several donors.

If I understand correctly, I think you mean adding some wording or something that makes the person who just donated feel special in some way, such as giving them a special opportunity to connect with us. I'm open to ideas here...not sure what to write at the moment, but perhaps we can table that part to the scope of a later issue.

@audreyfeldroy
Copy link
Member

@theflucs if you'd like, find me on Discord and we can chat about where to go from here: https://discord.gg/aGuWx7QE

@theflucs
Copy link
Author

@theflucs if you'd like, find me on Discord and we can chat about where to go from here: https://discord.gg/aGuWx7QE

I am on Discord, thanks 😃

@LowLifeArcade
Copy link
Collaborator

LowLifeArcade commented Sep 30, 2021

@theflucs I think you should just try your ideas and we can go from there. 🥳

@audreyfeldroy
Copy link
Member

It's also okay to get rid of text or move it to another temporary page to be placed elsewhere later. Much of that text on the Thank You page was stuff I wrote quickly to fill the page in a pinch. The story is that the page was an empty placeholder that looked weird with just a line of text, so I started filling it up with paragraphs off the top of my head.

@audreyfeldroy
Copy link
Member

I'll close this to help you start fresh @theflucs, and so you can qualify for Hacktoberfest. PRs created between Oct 1-31 count.

Try for tiny little PRs in smaller increments. Those are easier for maintainers to review, and easier to get merged in. And if you'd like to try little PRs on areas other than this page, that's fine too.

(Note: if you need me to reopen this, let me know, happy to🙂 )

@theflucs theflucs deleted the improve-thankyou-page branch October 11, 2021 09:19
@theflucs theflucs restored the improve-thankyou-page branch October 11, 2021 09:23
@theflucs theflucs deleted the improve-thankyou-page branch October 11, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants