-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style improvement: Thank you page #170
Style improvement: Thank you page #170
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/margaritahumanitarian/helpafamily/74CcvTuXRsqc3RSGw7EUgCBiZSQc |
Also, |
Thanks for the PR @theflucs and for your thoughtful comment for @arvind-1, who's also new to the project. That was his first merged PR 🎉 My idea about the 3 columns is that it's a good starting point for adding more functionality. I'm thinking we can move the top single column to the left, then provide a box with a receipt preview filling the right 2 columns. #135 shows an example of what a receipt preview might look like. Would you like to experiment with that @theflucs, either as part of this PR or in a new one? To limit scope, use fake mockup data for the layout. |
@audreyfeldroy Sure I can work on it, but I'm not sure I understood your idea. |
I have marked this as a draft while the page is still in discussion. |
Oh, I really like that @theflucs! Yes, I think that would be awesome. Feel free to experiment: it's okay to deviate from your proposal if you think the columns look better a different way. |
Hi @audreyfeldroy, please have a look at these changes. |
Sorry, I actually don't know if it's ready for review now 😅 |
I am still not convinced about the overall layout of this page though. |
Yes, agree about this, but in some way we need to add a contribution dialog that would be exclusive for only a few among several donors. |
Finally...! Thank you @marekrozmus! |
Hi @theflucs thanks so much for all your work on this! To address your comment:
Yes, I think this would improve the page a lot, and I see how it would be useful to have those sections throughout the site. To address @arvind-1's comment:
If I understand correctly, I think you mean adding some wording or something that makes the person who just donated feel special in some way, such as giving them a special opportunity to connect with us. I'm open to ideas here...not sure what to write at the moment, but perhaps we can table that part to the scope of a later issue. |
@theflucs if you'd like, find me on Discord and we can chat about where to go from here: https://discord.gg/aGuWx7QE |
I am on Discord, thanks 😃 |
@theflucs I think you should just try your ideas and we can go from there. 🥳 |
It's also okay to get rid of text or move it to another temporary page to be placed elsewhere later. Much of that text on the Thank You page was stuff I wrote quickly to fill the page in a pinch. The story is that the page was an empty placeholder that looked weird with just a line of text, so I started filling it up with paragraphs off the top of my head. |
I'll close this to help you start fresh @theflucs, and so you can qualify for Hacktoberfest. PRs created between Oct 1-31 count. Try for tiny little PRs in smaller increments. Those are easier for maintainers to review, and easier to get merged in. And if you'd like to try little PRs on areas other than this page, that's fine too. (Note: if you need me to reopen this, let me know, happy to🙂 ) |
Addressing closed issue #160 and open issue #1
Starting off from the awesome contribute of @arvind-1, I made some minor style adjustments.
I found the 3 columns at the bottom a bit confusing to read. But this is just my personal idea, so feel free to drop this pull request if you don't agree.
Cheers