Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code/fix and remove eslint errors #296

Conversation

ChrisBit
Copy link
Contributor

@ChrisBit ChrisBit commented Oct 20, 2021

This PR:

  • Use JSX.Element instead of ReactElement, so that we can avoid importing a otherwise unused import. Using JSX.Element should be good for most cases. But the best solution would probably be to switch to using TypeScript in .ts files.
  • Removes unneeded eslint-disable's

This PR aims to "Improve code in any way" issue #16

Self-Review Checklist

  • PR title is clear with proper spelling and grammar
  • PR description contains a bulleted list of changes contained in the PR
  • PR links to relevant issues, with keywords to auto-close any issues fully resolved upon merge
  • All automated checks passed - Lighthouse fails, but this is a unrelated, known issue [🪲] Errors in Lighthouse Automated Test [🪲] Errors in Lighthouse Automated Test #281.
  • Any variables introduced are named clearly and explicitly

@vercel
Copy link

vercel bot commented Oct 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/margaritahumanitarian/helpafamily/3a1bSBn7KD9HgKFAGeEpw8Xgn49y
✅ Preview: https://helpafamily-git-fork-chrisbit-impr-595f1b-margaritahumanitarian.vercel.app

@codecov-commenter
Copy link

Codecov Report

Merging #296 (57981ca) into main (f438bf2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #296   +/-   ##
=======================================
  Coverage   13.67%   13.67%           
=======================================
  Files          36       36           
  Lines         256      256           
  Branches       17       17           
=======================================
  Hits           35       35           
  Misses        206      206           
  Partials       15       15           
Impacted Files Coverage Δ
components/LandingPageNav.js 0.00% <ø> (ø)
components/LargeHeroContent.js 0.00% <ø> (ø)
components/LargeHeroSection.js 0.00% <ø> (ø)
pages/_app.js 0.00% <ø> (ø)
pages/_document.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f438bf2...57981ca. Read the comment docs.

Copy link
Collaborator

@LowLifeArcade LowLifeArcade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @ChrisBit. Thanks for contributing! Merging.

@LowLifeArcade LowLifeArcade merged commit 365ebbd into margaritahumanitarian:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants