Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add form link to button #27

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MilanAgrawal
Copy link

I have opened this pr again with the updations you have suggested still i am not very much familiar with the concept of converting buttons to links, i have tried and open to any suggestions

please check if it is correct, i am not completely sure about it.Thanks😊😊
I have tried it again but i am not exactly familiar with this concept of converting button to nextjs link ,i am still learning can u please tell if it works or if there is some other way for it, i woud be more than happy to contribute and i am open to any suggestions for changes
@vercel
Copy link

vercel bot commented Oct 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/margaritahumanitarian/laptopsforfamilies-org/FKSwhL7yJmkutmZ5zmhFcusQhz9C
✅ Preview: https://laptopsforfamilies-org-git-fork-mi-d0835f-margaritahumanitarian.vercel.app

Copy link
Contributor

@vincentrohde vincentrohde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation works and looks good to me. There are two small things (syntax and indentation) that will have to be changed 👍

@@ -2,8 +2,9 @@ import React from 'react';

import Head from 'next/head';
import Script from 'next/script';

import Link from 'next/link'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import Link from 'next/link'
import Link from 'next/link';

Comment on lines +575 to +576
<Link href="https://forms.gle/Sf3DDRHpDsLfQSyj7" passHref>
<button className="mx-auto lg:mx-0 hover:underline bg-white text-gray-800 font-bold rounded-full my-6 py-4 px-8 shadow-lg focus:outline-none focus:shadow-outline transform transition hover:scale-105 duration-300 ease-in-out">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be indented properly imo 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants