-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add form link to button #27
base: main
Are you sure you want to change the base?
Conversation
please check if it is correct, i am not completely sure about it.Thanks😊😊
I have tried it again but i am not exactly familiar with this concept of converting button to nextjs link ,i am still learning can u please tell if it works or if there is some other way for it, i woud be more than happy to contribute and i am open to any suggestions for changes
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/margaritahumanitarian/laptopsforfamilies-org/FKSwhL7yJmkutmZ5zmhFcusQhz9C |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation works and looks good to me. There are two small things (syntax and indentation) that will have to be changed 👍
@@ -2,8 +2,9 @@ import React from 'react'; | |||
|
|||
import Head from 'next/head'; | |||
import Script from 'next/script'; | |||
|
|||
import Link from 'next/link' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import Link from 'next/link' | |
import Link from 'next/link'; |
<Link href="https://forms.gle/Sf3DDRHpDsLfQSyj7" passHref> | ||
<button className="mx-auto lg:mx-0 hover:underline bg-white text-gray-800 font-bold rounded-full my-6 py-4 px-8 shadow-lg focus:outline-none focus:shadow-outline transform transition hover:scale-105 duration-300 ease-in-out"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be indented properly imo 👍
I have opened this pr again with the updations you have suggested still i am not very much familiar with the concept of converting buttons to links, i have tried and open to any suggestions