-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer process jsonl files #16
Comments
Hey @Asbjoern, thx for the report! 🤓 I have tried to reproduce your issue, but it is working as expected on my end. This is the console output when using the
Is the jsonl file you want to add or modify referenced in a cmd file? |
One some devices with only one file is is only referenced in the config.json:
but the problems persists with files referenced in boot.cmd: I have attached a test configuration direcotry that produces no output jsonl files on my end and no error messages.
But the output directory has no jsonl files:
|
Thx for providing the example 🚀 I can already say though that I definitely forgot about the As for the command reference, openhasp-config-manager assumes that files are referenced using absolute paths, starting with
to
it will work. I am not sure about supporting other forms, because I do not know how they work. The |
…es_processed Bugfix/#16 not all jsonl files processed
Just as a heads up: The config zip you uploaded references Please give 0.3.1 a try 🚀 |
Thank you very much! Now on the I get parsing errors. It does not accept urls as img src. But that seems like a different issue and I will open another issue. |
Yes, for that one it is easy, because it is a single config option that I know beforehand contains a path. Supporting different variants for that is not as hard as for the generic CMD files. It's also possible for them, but it requires a bit more logic and I haven't yet decided how I want to tackle this. |
Describe the bug
Changes to, or new jsonl files are no longer processed and moved to the output directory for upload.
Changes to cmd files works as expected
Problem persists in v0.3.0 and v0.2.0.
Everything works in v0.1.0
To Reproduce
Steps to reproduce the behavior:
Make changes to an existing jsonl file or create a new one.
Run generate or deploy
Observe that the changes has not made its way to the output directory or devices.
Expected behavior
I expected the changes to be uploaded to the devices.
Ubuntu server Python version 3.10.6
The text was updated successfully, but these errors were encountered: