Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize images with extension in ignore case maner #10

Merged
merged 2 commits into from
Jun 10, 2023

Conversation

yarikwest
Copy link
Contributor

#9

Copy link
Owner

@marlokessler marlokessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yarikwest, thank you for your pull request! I just have a small comment which should be included, otherwise this looks good to me.

server/services/image-optimizer-service.ts Outdated Show resolved Hide resolved
Co-authored-by: Marlo Kesser <[email protected]>
Signed-off-by: Yaroslav Zakhidnyi <[email protected]>
Copy link
Owner

@marlokessler marlokessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everything looks fine👍🏼

@marlokessler marlokessler added the bug Something isn't working label Jun 10, 2023
@marlokessler marlokessler merged commit baa1cd3 into marlokessler:main Jun 10, 2023
@marlokessler
Copy link
Owner

@all-contributors please add @yarikwest for bug and code .

@allcontributors
Copy link
Contributor

@marlokessler

I've put up a pull request to add @yarikwest! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants