Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow transforming for original size, support avif/heif quality #18

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

Cretezy
Copy link
Contributor

@Cretezy Cretezy commented Jun 12, 2023

Fixes #11

Copy link
Owner

@marlokessler marlokessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Cretezy, thank you for your contribution. I reviewed it and added some comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
server/services/image-optimizer-service.ts Show resolved Hide resolved
@Cretezy
Copy link
Contributor Author

Cretezy commented Jun 12, 2023

@marlokessler Comments addressed

Copy link
Owner

@marlokessler marlokessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cretez, looks good to me! Thank you for your contribution!

@marlokessler marlokessler added the enhancement New feature or request label Jun 30, 2023
@marlokessler marlokessler merged commit 435b9b4 into marlokessler:main Jun 30, 2023
@marlokessler
Copy link
Owner

@all-contributors please add @Cretezy for code and doc.

@allcontributors
Copy link
Contributor

@marlokessler

I've put up a pull request to add @Cretezy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow optimizing for format, but not size
2 participants