Update Tauri Deps #758
Merged
Update Tauri Deps #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to upgrade `ts-rs` to v8, but the new export mechanism is extremely confusing, and `TS_RS_EXPORT_DIR` does not seem to be respected (types should be outputted in the TS codebase, not the rust codebase).
|
Did you consider using schemars to generate TypeScript from an intermediate JSON Schema definition? |
|
Well, ts-rs does everything in one go. Probably we could automate the types generation when using |
martpie
added a commit
that referenced
this pull request
Jun 13, 2024
I tried to upgrade `ts-rs` to v8, but the new export mechanism is extremely confusing, and `TS_RS_EXPORT_DIR` does not seem to be respected (types should be outputted in the TS codebase, not the rust codebase).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to upgrade
ts-rsto v8, but the new export mechanism is extremely confusing, andTS_RS_EXPORT_DIRdoes not seem to be respected (types should be outputted in the TS codebase, not the rust codebase).