-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helm folder icon #1181
Add Helm folder icon #1181
Conversation
@PKief is everything to your satisfaction |
c149f3c
to
6ed12b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@PKief Is there anything that prevents this pull request from getting merged? |
640fb8a
to
d5912bb
Compare
@PKief Any update on this? :) |
eeb4f0e
to
b2e0fe4
Compare
Signed-off-by: Philipp Kief <[email protected]>
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the marketplace. |
Boy, I thought that I staled many PRs but this is crazy 🤣 3 yrs to merge one 😅 |
Miracles do happen 😉 With the large number of pull requests and issues, not all of them can always be answered, especially if they are wobbly candidates - i.e. if it is not certain whether an icon fits in. From time to time, however, we also go through the older topics and check again whether we can bring it in. |
Added icon for helm folders: