Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm folder icon #1181

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Add Helm folder icon #1181

merged 7 commits into from
Jul 5, 2024

Conversation

sullrich84
Copy link
Contributor

Added icon for helm folders:

  • helm
  • helmchart
  • helmcharts
  • .helm
  • .helmchart
  • .helmcharts

@sullrich84
Copy link
Contributor Author

@PKief is everything to your satisfaction

@PKief PKief force-pushed the main branch 9 times, most recently from c149f3c to 6ed12b6 Compare January 23, 2022 19:28
Copy link

@moraesjeremias moraesjeremias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@LukeTimeWalker
Copy link
Contributor

@PKief Is there anything that prevents this pull request from getting merged?

@Netail
Copy link
Contributor

Netail commented Apr 18, 2024

@PKief Any update on this? :)

Signed-off-by: Philipp Kief <[email protected]>
@PKief PKief self-requested a review July 5, 2024 19:10
Copy link

github-actions bot commented Jul 5, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link

github-actions bot commented Jul 5, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@PKief PKief merged commit 89730d4 into material-extensions:main Jul 5, 2024
9 checks passed
Copy link

github-actions bot commented Jul 5, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link

github-actions bot commented Jul 5, 2024

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

@moraesjeremias
Copy link

Boy, I thought that I staled many PRs but this is crazy 🤣

3 yrs to merge one 😅

@PKief
Copy link
Member

PKief commented Jul 6, 2024

Miracles do happen 😉 With the large number of pull requests and issues, not all of them can always be answered, especially if they are wobbly candidates - i.e. if it is not certain whether an icon fits in. From time to time, however, we also go through the older topics and check again whether we can bring it in.

@mallowigi
Copy link

I made this choice of colors:
CleanShot 2024-07-07 at 14 18 43

in your icon the contrast between the folder and the icon is too low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants