-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forge file extension support #2243
base: main
Are you sure you want to change the base?
Conversation
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
d4fd512
to
36938b9
Compare
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
bd43548
to
9debb03
Compare
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
85f0b0e
to
6ad7041
Compare
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
Closes #1990 |
Could be merged together with #1078 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon is not fitting into the theme like this. I don't like the grey background. On a dark theme it's not even visible very well.
Hi @PKief, I've used the official logo. Do you have some idea about the dark theme? I was think removing the grey background and use only the logo. WDYT? |
eeb4f0e
to
b2e0fe4
Compare
2ff604a
to
b1ad1d2
Compare
Add support for electron forge,
forge.config.js
file.Dark theme
![Screenshot 2024-03-04 at 11 18 48 PM](https://private-user-images.githubusercontent.com/3688905/309962626-ad495061-19ad-45f9-a15d-e458bfc3823e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2NjEzMTEsIm5iZiI6MTcyMTY2MTAxMSwicGF0aCI6Ii8zNjg4OTA1LzMwOTk2MjYyNi1hZDQ5NTA2MS0xOWFkLTQ1ZjktYTE1ZC1lNDU4YmZjMzgyM2UucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjJUMTUxMDExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWQ4NGQzNDZlYjI1NDMxMzZhZDYxMTQ1NTI4ZjMxMGU4ZjNhNzc4NmU1MDdjNjk3YWVmNzdiM2U5M2M1NzQ0ZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.7hDBKpf3voHdAT0CF9W0Ifs4C9QgQN0gF5CpDQ0XFME)
Light Theme
![Screenshot 2024-03-04 at 11 19 09 PM](https://private-user-images.githubusercontent.com/3688905/309962631-f4a79ad0-2da3-4549-a5ed-a2cd7650d8f7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2NjEzMTEsIm5iZiI6MTcyMTY2MTAxMSwicGF0aCI6Ii8zNjg4OTA1LzMwOTk2MjYzMS1mNGE3OWFkMC0yZGEzLTQ1NDktYTVlZC1hMmNkNzY1MGQ4ZjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjJUMTUxMDExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTc0NTExM2U4YjZiOTBkODM4ZjQwYjNjZWM3NTMxZTQxMDgwMjE1N2U2OGI2Zjk3YTBhYjBjZTFiN2UyOTM3ZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Aot2tgpYMlYieM0C4ZTZTlLFil-W9c6b6n5vJ5n-GrM)