-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ⚙️ Refactor pattern code structure #2326
Conversation
…theme into feat/refactor-pattern-code
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the marketplace. |
Looks like the |
Which extensions are missing? |
Run: import { fileIcons } from './fileIcons';
const io = fileIcons.icons[220].fileNames?.join('\n');
console.log(io); Get:
|
@Airkro thanks a lot, no it was not on purpose to remove some patterns. I've restored it, so that it should cover all patterns now: https://github.com/PKief/vscode-material-icon-theme/commit/fe98e7ce1e96ccd837712eb9652e1b55a748bae8. The reason for the refactoring was to make the code more self-explanatory and more explicit what kind of file names are used for each pattern. I know that the code looks a bit more comprehensive but I prefer it that way. |
These lines should be removed, they are not part of Cosmiconfig. |
We should add some test cases for |
@Airkro thanks for the hint. I've updated the code and also added a unit test for the See commit: https://github.com/PKief/vscode-material-icon-theme/commit/d8bdd337e43b17c1b9b9ead72ef50db680283175 |
* feat: ⚙️ Refactor pattern code structure (#2326) * feat: ⚙️ Refactor pattern code structure * Rename type * feat: update barrels * feat: update recommended extensions for development * Add comment * fix: `pull_request_template.md` (#2339) Change from `[ ]` to real checkbox ☑️ * Added icon for kcl lang * Fixed `kcl` icon colors * Added some space around icon * Make icon pixel perfect to 32px grid --------- Signed-off-by: Philipp Kief <[email protected]> Co-authored-by: Philipp Kief <[email protected]> Co-authored-by: Anselm Hahn <[email protected]>
Reduce amount of code and amount of logic to apply the patterns to the file icons.