Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: provenance #2365

Merged
merged 7 commits into from
Jun 16, 2024
Merged

chore: provenance #2365

merged 7 commits into from
Jun 16, 2024

Conversation

lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Jun 13, 2024

I decided to look at the diff for 314aba7 and noticed it touched automated publishing. This is minor improvement to that flow that allows consumers to verify that the code did come from github actions, and wasn't created locally with a backdoor. This can prevent certain very specific supply-chain attacks.
I don't know why anyone would care, but someone probably will eventually complain, so it's better to do it now than latter. Although, in all seriousness, there are much better vectors for breaking into builds, and this doesn't help much without SHA pinning (I can do as well that if you'd like). Nevertheless, It doesn't hurt anything and I already had the the tab open 🙃

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for the explanation and the fix 😃 I'm not too experienced with SHA pinning. If you could add it to improve the security of my automated pipelines, I would be very grateful for it!

@lishaduck
Copy link
Contributor Author

Great, thank you for the explanation and the fix 😃 I'm not too experienced with SHA pinning. If you could add it to improve the security of my automated pipelines, I would be very grateful for it!

I should be able to get to it in a few hours! :)

Copy link
Contributor Author

@lishaduck lishaduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're officially secure 😉
I've done as much to your actions as I know 🕵️‍♂️

.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/pr-closed.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@lishaduck
Copy link
Contributor Author

lishaduck commented Jun 15, 2024

Oh, just FYI: I'm going on vacation for a ~week, so while I'm happy to help fix it if something broke, I won't be around until next Thursday. From experience, "resource not accessible from integration" errors can be rather annoying. 🤞 it works, but still 🤷‍♂️
To be clear: everything except the last commit should be fine. I tested the Bun scripting locally, and everything else is trivial enough it should be fine, but it is CI/CD... 🙃 The permissions key is pretty hard to get right though.

@lishaduck lishaduck requested a review from PKief June 15, 2024 01:55
@PKief PKief merged commit 8685463 into material-extensions:main Jun 16, 2024
1 check passed
Copy link

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

@lishaduck lishaduck deleted the patch-1 branch June 16, 2024 13:52
@lishaduck
Copy link
Contributor Author

Yay! It works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants