Replace generated image previews instead of creating new ones #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okineadev
suggested changes
Jul 4, 2024
lishaduck
force-pushed
the
better-pr-comments
branch
from
d85d62d
to
4ee90fa
Compare
okineadev
reviewed
Jul 4, 2024
lishaduck
force-pushed
the
better-pr-comments
branch
from
4ee90fa
to
d0e74e4
Compare
PKief
approved these changes
Jul 4, 2024
okineadev
reviewed
Jul 5, 2024
PKief
force-pushed
the
main
branch
2 times, most recently
from
2ff604a
to
b1ad1d2
Compare
Co-authored-by: Okinea Dev <[email protected]>
Co-authored-by: Okinea Dev <[email protected]>
lishaduck
force-pushed
the
better-pr-comments
branch
from
800b3df
to
1d81155
Compare
I've tested and adjusted it to make it work. We can merge it now. |
PKief
approved these changes
Jul 6, 2024
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the marketplace. |
lishaduck
commented
Jul 7, 2024
PKief
added a commit
that referenced
this pull request
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the image preview comments got really long in #2383, so I fixed it.
If you'd like to prevent another #2385, I guess I could make a random edit, check it works, then revert it.