ci: 🔄 add link to check pixel perfectness in preview comment #2405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
tl;dr
adds a link in the "preview comment" to a tool that lets you see how the icon fits in
a 16x16 grid
Hi!
A while ago, my team and I developed a simple internal tool to check if the icons added by a PR fit ok in a 16x16 pixel grid. A few days ago, we decided to make it open source, adapt it to work with any github repo and hosted it on the web.
Basically, what the web app does is query the GitHub API to get the SVG files added or modified by a PR and display them with an overlaid grid to quickly see if there are any issues. Nothing too fancy, but it ended up being quite useful for us.
This PR simply adds a link referencing the webapp rout to the current PR.
Here's an example:
https://pixp.lucode.ar/material-extensions/vscode-material-icon-theme/pull/2382
The source code for the application can be found at lucodear/pixp
I'm opening this PR as a draft to see if you find it interesting and because the web is hosted on our domain. But you can host it in your own domain if you want! We are using cloudflare.
Cheers!