-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose generateManifest as reusable function #2411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…material-icon-theme into chore/expose-module
…material-icon-theme into chore/expose-module
…material-icon-theme into chore/expose-module
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the marketplace. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
A comprehensive refactoring of the files and modules of this extension to be able to differentiate better between code which is related to the
vscode
library.By using the sheriff library dependencies between the modules can be verified. The command
bun run verify
checks if the imports between the modules are allowed. For instance it's not allowed, that any of the other modules imports something from theextension
module because of it's dependency tovscode
. But theextension
module itself is allowed to import fromcore
.This is realized by using the dependency rules in the sheriff.config.ts file:
If a file inside of the core module references something from the extension module the following error is thrown:
Additional changes
In addition, the library
lodash-es
has been added as dependency to remove some code. It replaces the dependencylodash.merge
and some get and set functions which have been written manually before. The bundle size is similar to before aslodash-es
can be tree-shaked.With the "tsconfig.declarations.json" the type definitions for the npm module are generated.