union domain implementation #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SpartaKushK
commented
Jun 12, 2023
SpartaKushK
commented
- main file
- docstrings
dario-coscia
requested changes
Jun 12, 2023
|
Please also add tests for the implementation, like in |
dario-coscia
requested changes
Jun 13, 2023
dario-coscia
requested changes
Jun 13, 2023
|
I left some comments, I think that once these are fixed it can be merge from my side. |
dario-coscia
requested changes
Jun 14, 2023
- main file - docstrings
- minor edits to union - added Union to __init__.py of geometry
- CartesianDomains - EllipsoidDomain - CartesianDomain and EllipsoidDomain
- renamed tests cases - add param type for __init__
- added a location check in __init__ - return a label tensor in sample with labels 'x0', 'x1'...
- ensures dimensions of geometries are same - sampling improved - test case typo fixed
- make `geometries` private - formatting
|
👋🏻@ndem0 . I have finished the review of @SpartaKushK code. For my side it can be merge, let me know if you think we missed something |
|
yes, well done @SpartaKushK @dario-coscia! |
ndem0
pushed a commit
that referenced
this pull request
Jul 27, 2023
* Union Class * Implemented Union Tests --------- Co-authored-by: Dario Coscia <[email protected]>
ndem0
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Union Class * Implemented Union Tests --------- Co-authored-by: Dario Coscia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.