Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplex Domain #152

Merged
merged 8 commits into from
Jul 14, 2023
Merged

Simplex Domain #152

merged 8 commits into from
Jul 14, 2023

Conversation

benv123
Copy link
Contributor

@benv123 benv123 commented Jul 10, 2023

  • Simplex Domain
  • Tests
  • Init

@dario-coscia dario-coscia mentioned this pull request Jul 10, 2023
Closed
dario-coscia
dario-coscia requested changes Jul 10, 2023
View reviewed changes
pina/geometry/simplex.py Outdated Show resolved Hide resolved
pina/geometry/simplex.py Outdated Show resolved Hide resolved
@dario-coscia dario-coscia added the pr-to-fix Label for PR that needs modification label Jul 10, 2023
@dario-coscia dario-coscia mentioned this pull request Jul 12, 2023
Closed
@dario-coscia dario-coscia self-requested a review July 12, 2023 12:12
@dario-coscia dario-coscia added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Jul 12, 2023
@dario-coscia dario-coscia requested a review from ndem0 July 12, 2023 12:13
@dario-coscia
Copy link
Collaborator

@ndem0 From my side the PR can be merged. @benv123 Did an amazing job in implementing sampling on arbitrary dimensions Simplex. We have both sampling on the interior and on the boundary.

@ndem0 ndem0 merged commit ef7eeb6 into mathLab:v0.1 Jul 14, 2023
10 of 13 checks passed
ndem0 pushed a commit that referenced this pull request Jul 27, 2023
@benv123 @dario-coscia @ndem0
Simplex Domain (#152)
a241463 
* add Simplex Domain 
* unittests for Simplex
* docs update

---------

Co-authored-by: Dario Coscia <[email protected]>
ndem0 pushed a commit that referenced this pull request Nov 17, 2023
@benv123 @dario-coscia @ndem0
Simplex Domain (#152)
38ecebd 
* add Simplex Domain 
* unittests for Simplex
* docs update

---------

Co-authored-by: Dario Coscia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dario-coscia dario-coscia dario-coscia approved these changes

@ndem0 ndem0 Awaiting requested review from ndem0

Assignees
No one assigned
Labels
pr-to-review Label for PR that are ready to been reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benv123 @dario-coscia @ndem0