PBC Layer #252
Merged
PBC Layer #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndem0
reviewed
Feb 26, 2024
| can correctly compute the PBC on the derivatives up to the order | ||
| :math:`\sim 2,3`, while it is not guarantee the periodicity for | ||
| :math:`>3`. The PINA code is tested only for function PBC and not for | ||
| its derivatives. |
There was a problem hiding this comment.
A small example to show the minimal usage
There was a problem hiding this comment.
ok I will add it.
ndem0
reviewed
Feb 26, 2024
pina/model/layers/embedding.py
Outdated
| @@ -0,0 +1,142 @@ | |||
| """ Embedding modulus. """ | |||
There was a problem hiding this comment.
Periodic Boundary Embedding module
There was a problem hiding this comment.
In the future I plan to put other embeddings, that's why I used this name. What do you think?
There was a problem hiding this comment.
But I would keep one class per file, it's cleaner
ndem0
reviewed
Feb 26, 2024
pina/model/layers/embedding.py
Outdated
| from pina.utils import check_consistency | ||
|
|
||
|
|
||
| class PBCEmbedding(torch.nn.Module): |
There was a problem hiding this comment.
What about the extended class name? PeriodicBoundaryEmbedding maybe? Too many acronyms make things very complex for new user
There was a problem hiding this comment.
PeriodicBoundaryEmbeddingBlock ?
dario-coscia
force-pushed
the
trigfeatures
branch
from
5e7f0f7
to
85c6646
Compare
AleDinve
pushed a commit
to AleDinve/PINA
that referenced
this pull request
Mar 4, 2024
* update docs/tests * tutorial and device fix --------- Co-authored-by: Dario Coscia <[email protected]> Co-authored-by: Dario Coscia <[email protected]> Co-authored-by: Dario Coscia <[email protected]> Co-authored-by: Dario Coscia <[email protected]>
AleDinve
pushed a commit
to AleDinve/PINA
that referenced
this pull request
Mar 25, 2024
* update docs/tests * tutorial and device fix --------- Co-authored-by: Dario Coscia <[email protected]> Co-authored-by: Dario Coscia <[email protected]> Co-authored-by: Dario Coscia <[email protected]> Co-authored-by: Dario Coscia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a PBC layer for square domains.