Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test PeriodicBoundaryEmbedding #257

Merged
merged 2 commits into from
Mar 4, 2024
Merged

fix test PeriodicBoundaryEmbedding #257

merged 2 commits into from
Mar 4, 2024

Conversation

dario-coscia
Copy link
Collaborator

@dario-coscia dario-coscia commented Mar 4, 2024

Small fix in the torch.allclose, fixing the atol=1e-6 and comparing residuals with zeros for stability

@dario-coscia
Copy link
Collaborator Author

Test fails since matplolib 3.8.0 does not currently work with the plotter class, see #209 . merging

@dario-coscia dario-coscia merged commit 15136e1 into master Mar 4, 2024
15 of 16 checks passed
@dario-coscia dario-coscia deleted the fix branch March 4, 2024 10:50
AleDinve pushed a commit to AleDinve/PINA that referenced this pull request Mar 4, 2024
* fix test PeriodicBoundaryEmbedding
* fix tests
guglielmopadula pushed a commit to guglielmopadula/PINA that referenced this pull request Mar 4, 2024
* fix test PeriodicBoundaryEmbedding
* fix tests
AleDinve pushed a commit to AleDinve/PINA that referenced this pull request Mar 25, 2024
* fix test PeriodicBoundaryEmbedding
* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant