Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equation Class Tutorial #287

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Equation Class Tutorial #287

merged 4 commits into from
Apr 18, 2024

Conversation

AleDinve
Copy link
Collaborator

Equation class tutorial (see #248)

@dario-coscia
Copy link
Collaborator

dario-coscia commented Apr 16, 2024 •
edited
Loading

Hi! Thanks for the PR! Some conflicts are going on, can you solve them? Did you fetch and rebase with master?

@dario-coscia dario-coscia added the pr-to-fix Label for PR that needs modification label Apr 16, 2024
@dario-coscia
Copy link
Collaborator

dario-coscia commented Apr 17, 2024 •
edited
Loading

Hi! Thanks for the PR! Some conflicts are going on, can you solve them? Did you fetch and rebase with master?

👋🏻 @AleDinve there were some issues with the GitHub history, I fixed them. I uploaded the tutorial12/tutorial.ipynb and tutorial12/tutorial.py.

Can you update the ReadMe.md in tutorials, the _tutorial.rst file in docs/source/_rst and add the tutorial12 folder in docs/source/_rst/tutorials ?

Then we merge!

@AleDinve
Copy link
Collaborator Author

Solved 👍

@dario-coscia dario-coscia self-requested a review April 18, 2024 11:14
@dario-coscia dario-coscia added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Apr 18, 2024
dario-coscia
dario-coscia approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @AleDinve ! 👏

@dario-coscia dario-coscia merged commit 7b86661 into mathLab:master Apr 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dario-coscia dario-coscia dario-coscia approved these changes

Assignees

@AleDinve AleDinve

@dario-coscia dario-coscia

Labels
pr-to-review Label for PR that are ready to been reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AleDinve @dario-coscia