Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Date/Time into Date, Time and DateTime types #21

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Split Date/Time into Date, Time and DateTime types #21

merged 2 commits into from
Jan 19, 2022

Conversation

ghislaineguerin
Copy link
Contributor

This PR updates the spec for date/time data type design based on this issue

@ghislaineguerin ghislaineguerin requested a review from a team as a code owner January 13, 2022 09:42
@github-actions github-actions bot requested review from eito-fis, kgodey, mathemancer, pavish, seancolsen and silentninja and removed request for a team January 13, 2022 09:43
kgodey
kgodey approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@kgodey kgodey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seancolsen seancolsen removed their assignment Jan 13, 2022
@mathemancer mathemancer removed their assignment Jan 14, 2022
@kgodey kgodey removed their assignment Jan 14, 2022
@pavish pavish removed their assignment Jan 17, 2022
@ghislaineguerin ghislaineguerin merged commit e39d00f into master Jan 19, 2022
@ghislaineguerin ghislaineguerin deleted the date-time-spec-update branch January 19, 2022 09:21
@ghislaineguerin ghislaineguerin added the work: design Improvements or additions to design. Should also have "Restricted: Design Team" label label Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgodey kgodey kgodey approved these changes

@eito-fis eito-fis Awaiting requested review from eito-fis

@mathemancer mathemancer Awaiting requested review from mathemancer

@pavish pavish Awaiting requested review from pavish

@seancolsen seancolsen Awaiting requested review from seancolsen

@silentninja silentninja Awaiting requested review from silentninja

Assignees

@dmos62 dmos62

@silentninja silentninja

Labels
work: design Improvements or additions to design. Should also have "Restricted: Design Team" label
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ghislaineguerin @kgodey @seancolsen @dmos62 @silentninja @mathemancer @pavish