Skip to content

Commit

Permalink
Switch to defacto way to specify max_length
Browse files Browse the repository at this point in the history
  • Loading branch information
dmos62 committed Mar 3, 2022
1 parent a69ec81 commit 27f75ca
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions mathesar/api/serializers/shared_serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,29 +111,24 @@ class NumberDisplayOptionSerializer(MathesarErrorMessageMixin, OverrideRootParti
show_as_percentage = serializers.BooleanField(default=False)
locale = serializers.CharField(required=False)


def raise_if_duration_format_invalid(format):
if 'z' in format.lower():
raise serializers.ValidationError(
"Duration column cannot contain timezone display format"
)

def raise_if_time_format_invalid(format):
if isinstance(format, str) and len(format) <= 255:
return
else:
raise serializers.ValidationError("Time format string not a string or longer than 255 characters.")


class TimeFormatDisplayOptionSerializer(
MathesarErrorMessageMixin,
OverrideRootPartialMixin,
serializers.Serializer
):
format = serializers.CharField(validators=[raise_if_time_format_invalid])
format = serializers.CharField(max_length=255)


class DurationDisplayOptionSerializer(MathesarErrorMessageMixin, OverrideRootPartialMixin, serializers.Serializer):
format = serializers.CharField(validators=[raise_if_duration_format_invalid])
format = serializers.CharField(max_length=255, validators=[raise_if_duration_format_invalid])


class DisplayOptionsMappingSerializer(
Expand Down

0 comments on commit 27f75ca

Please sign in to comment.