Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation for text data type #244

Closed
7 tasks done
kgodey opened this issue Jun 14, 2021 · 4 comments
Closed
7 tasks done

Implementation for text data type #244

kgodey opened this issue Jun 14, 2021 · 4 comments
Labels
pr-status: revision A PR awaiting follow-up work from its author after review type: meta List of related issues. Not meant to be worked on directly.

Comments

@kgodey
Copy link
Contributor

kgodey commented Jun 14, 2021

Problem

Users will want to store text data in columns. We should allow them to do so and implement this type appropriately in the backend.

Proposed solution

We should support Text types in Mathesar and allow users to use them.

Tasks that need to completed:

Additional context

Related issues and PRs:

@kgodey kgodey added type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL work: database ready Ready for implementation labels Jun 14, 2021
@kgodey kgodey added this to the 8. Initial Data Types milestone Jun 14, 2021
@kgodey kgodey changed the title Backend implementation for text data type Backend/API implementation for text data type Jun 14, 2021
@mathemancer
Copy link
Contributor

Unless we have a specific reason to use TEXT, we should probably use VARCHAR for the column type even when unlimited. This will make it easier to work with. (There shouldn't really be any difference in the DB between TEXT and unlimited-length VARCHAR w.r.t. performance and whatnot.)

@kgodey
Copy link
Contributor Author

kgodey commented Jun 18, 2021

@mathemancer Updated the ticket. I also added a section about reflecting existing TEXT fields correctly.

@kgodey kgodey added status: detail needed type: meta List of related issues. Not meant to be worked on directly. ready Ready for implementation and removed ready Ready for implementation type: enhancement New feature or request status: detail needed labels Jul 15, 2021
@rootxnet
Copy link

rootxnet commented Aug 2, 2021

Working on it.

@kgodey kgodey changed the title Backend/API implementation for text data type Implementation for text data type Sep 13, 2021
@kgodey kgodey added work: product and removed work: backend Related to Python, Django, and simple SQL work: database labels Sep 13, 2021
@kgodey kgodey added pr-status: revision A PR awaiting follow-up work from its author after review and removed ready Ready for implementation labels Mar 1, 2022
@kgodey
Copy link
Contributor Author

kgodey commented May 4, 2022

Closing this since all subtasks are done.

@kgodey kgodey closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review type: meta List of related issues. Not meant to be worked on directly.
Projects
No open projects
Development

No branches or pull requests

3 participants