Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filtering options for Text types. #406

Closed
Tracked by #244
kgodey opened this issue Jul 16, 2021 · 2 comments · Fixed by #1079
Closed
Tracked by #244

Implement filtering options for Text types. #406

kgodey opened this issue Jul 16, 2021 · 2 comments · Fixed by #1079
Assignees
Labels
type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL

Comments

@kgodey
Copy link
Contributor

kgodey commented Jul 16, 2021

Problem

We need to ensure that records that include columns of all Text types support the following filters via API:

  • contains {x}
  • is {x}
  • is not {x}
  • starts with {x}
  • ends with {x}
  • does not contain {x}
  • does not start with {x}
  • does not end with {x}
  • is empty
  • is not empty

This involves:

  • Implementing the filters in the backend
  • Updating the /api/v0/databases/<id>/types/ endpoint to store available filters on this type
    • Filter information should include the number of parameters needing to be passed in (e.g. contains needs 1 parameter, is empty needs 0)

Additional context

@kgodey kgodey added needs: unblocking Blocked by other work type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL work: database labels Jul 16, 2021
@kgodey kgodey added this to the 07. Initial Data Types milestone Jul 16, 2021
@kgodey kgodey added ready Ready for implementation and removed needs: unblocking Blocked by other work labels Nov 11, 2021
@dmos62 dmos62 self-assigned this Dec 9, 2021
@dmos62 dmos62 added status: started and removed ready Ready for implementation labels Dec 10, 2021
@dmos62 dmos62 mentioned this issue Dec 10, 2021
7 tasks
@dmos62
Copy link
Contributor

dmos62 commented Dec 10, 2021

@kgodey Should we have a way to filter in a case-insensitive manner?

@kgodey
Copy link
Contributor Author

kgodey commented Dec 10, 2021

@dmos62 Yes, we should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
No open projects
3 participants