-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend text filtering #879
Conversation
Updated to the status to blocked, since it is blocked by #837 |
Here's what the new entries in the
Notice: The settings are provided like this:
The architecture around how we deal with predicate settings, like case-sensitivity in this case, is minimalistic and fluid at the moment since requirements aren't clear yet. We're currently working from simple cases to more complex ones, so I expect refinement to take place in future PRs when more interesting predicates are explored. |
@dmos62 I made this PR a draft so we don't accidentally merge it. I think it's fine for the |
@kgodey this last commit makes internal nomenclature changes you requested: super type -> position, type -> id. It makes some other significant changes too; I forgot to commit before making other changes. |
I reflected on this a bit and decided that introducing changes only to the last PR when they are relevant to a series of PRs is not a good idea. Next time, I'll commit to the oldest PR and merge the older PR into the newer PRs. |
Agreed, I assumed it was because the other PR was based on a fork and this is a branch. I do think it's always better to make it on the older PR. |
@dmos62 Can we close this PR since it's pretty out of date? |
Fixes #406
Depends on previous filtering PR: #837
Introduces
StartsWith
,EndsWith
andContains
predicates for text types. These predicates accept acase_sensitive
setting (defaults toTrue
).Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin