Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend implementation for Email Mathesar type #255

Closed
Tracked by #245
kgodey opened this issue Jun 14, 2021 · 2 comments
Closed
Tracked by #245

Frontend implementation for Email Mathesar type #255

kgodey opened this issue Jun 14, 2021 · 2 comments
Assignees
Labels
ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory

Comments

@kgodey
Copy link
Contributor

kgodey commented Jun 14, 2021

Requirements

Users should be able to:

  • view data in columns that have the Mathesar email custom type
  • see validation errors if the data they enter is not a valid email
  • change data type to and from the email DB type
  • view, set, and change data type options related to email data type
  • group data by email-specific grouping options
  • filter data by email-specific filtering options

Update:

DB Type Mapping

All columns of this type map to MATHESAR_TYPES.EMAIL. Please note that we should make sure it's available before showing it as an available type.

Implementation

Design

Backend

  • /api/v0/tables/ lists the name and DB type of each columns
  • /api/v0/tables/<id/columns/ lists column information in more detail
  • /api/v0/databases/<id>/types/ maps Mathesar types to DB types and provides a list of filtering and grouping options per-type.
    • These should be used to populate the filter and grouping options dynamically.
    • This should also be used to determine the availability of the email type on a given database. It is a custom type so it's not available on all databases.
  • Updates to column types and type options should happen via PATCH requests to /api/v0/tables/<id>/columns/<id>/. These updates include
    • Changes to the data type (type)

Additional Context

@kgodey kgodey added type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory needs: unblocking Blocked by other work status: detail needed labels Jun 14, 2021
@kgodey kgodey added this to the 8. Initial Data Types milestone Jun 14, 2021
@kgodey kgodey changed the title Frontend implementation for email data types Frontend implementation for email data type Jun 14, 2021
@kgodey kgodey removed the needs: unblocking Blocked by other work label Jun 18, 2021
@kgodey kgodey added needs: unblocking Blocked by other work and removed status: draft labels Sep 13, 2021
@kgodey kgodey changed the title Frontend implementation for email data type Frontend implementation for Email Mathesar type Sep 13, 2021
@kgodey kgodey added ready Ready for implementation and removed needs: unblocking Blocked by other work labels Mar 1, 2022
@kgodey
Copy link
Contributor Author

kgodey commented Mar 1, 2022

Marking this as ready since filtering and grouping have been moved to other issues and remaining backend work is done.

@seancolsen seancolsen self-assigned this Apr 14, 2022
@seancolsen
Copy link
Contributor

Most of the work here appears to be done, so I'm closing this ticket in favor of a few remaining tickets that are more specific.

To address this ticket's requirements:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

No branches or pull requests

2 participants