-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Date & Time data type into three Mathesar types #960
Comments
I think |
I think it will be confusing for |
Now that the design for this is done, we need to make sure the backend reflects the new types correctly. We should make sure the Mathesar Types API, display options, etc. all work correctly based on the new design. |
@pavish @seancolsen currently the display options for the
What should the display options for the upcoming
|
@dmos62 Please consult the display options in the Jan 2022 date time prototype in the Global Date Time Components design spec. It seems like we need either a |
@kgodey I'm still wrapping my head around display options and their current state. I guess I see @mathemancer submitted a PR adding this same display option ( |
@dmos62 I think we need separate date and time formats for Date & Time (so that the user can set separate formats for the date and time component). Dates would just use the date format and Times would use the time format. So that means:
The single Durations are represented differently and the format for durations shouldn't affect this issue. |
@kgodey oh, my monitor is in profile and the datetime prototype was out of view so I couldn't see it until I started panning. Ok, I'll create |
Problem
Based on the new definition of Mathesar Data Types, it makes sense to split up the Date & Time type into three types:
Proposed solution
We need to update the data type design specs to create specs for
Date
andTime
and update theDate & Time
specs to remove the options for date-only and time-only database options.Additional context
The text was updated successfully, but these errors were encountered: