You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the column dropping function uses the column index to identify columns. This is brittle, and we've decided to change to using the attnum property of columns instead.
Proposed solution
The function in db/columns/operations/drop.py should use attnum instead of column_index, and should properly use the table_oid, attnum pair to identify columns for its logic. Use the function get_column_name_from_attnum in the db.columns.operations.select module for this.
Additional context
We'll need to modify any place where the function is called as well.
The text was updated successfully, but these errors were encountered:
kgodey
removed
good first issue
Everything in "Help wanted", PLUS being relatively easy and straightforward to implement.
help wanted
Community contributors can implement this
labels
Mar 1, 2022
Problem
Currently, the column dropping function uses the column index to identify columns. This is brittle, and we've decided to change to using the
attnum
property of columns instead.Proposed solution
The function in
db/columns/operations/drop.py
should useattnum
instead ofcolumn_index
, and should properly use thetable_oid, attnum
pair to identify columns for its logic. Use the functionget_column_name_from_attnum
in thedb.columns.operations.select
module for this.Additional context
We'll need to modify any place where the function is called as well.
The text was updated successfully, but these errors were encountered: