Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Column dropping operations to use attnum instead of column index #1106

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

silentninja
Copy link
Contributor

@silentninja silentninja commented Mar 1, 2022

Fixes #993

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@silentninja silentninja requested a review from a team March 1, 2022 01:40
@github-actions github-actions bot requested review from dmos62, eito-fis, kgodey, mathemancer and pavish and removed request for a team March 1, 2022 01:41
@kgodey
Copy link
Contributor

kgodey commented Mar 1, 2022

@silentninja This depends on a draft PR, please mark it as a draft too.

@kgodey kgodey self-assigned this Mar 1, 2022
@kgodey kgodey marked this pull request as draft March 1, 2022 18:11
@kgodey kgodey added the pr-status: review A PR awaiting review label Mar 1, 2022
Copy link
Contributor

@kgodey kgodey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please merge when the base PR is merged.

@kgodey kgodey added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Mar 2, 2022
@kgodey kgodey removed their assignment Mar 2, 2022
Base automatically changed from mathesar-992-attnum-column-selection- to master March 3, 2022 00:45
@silentninja silentninja marked this pull request as ready for review March 3, 2022 01:09
@silentninja silentninja linked an issue Mar 3, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #1106 (6e8f695) into master (eb4b5e4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1106   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files         112      112           
  Lines        4248     4249    +1     
=======================================
+ Hits         3967     3968    +1     
  Misses        281      281           
Flag Coverage Δ
pytest-backend 93.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
db/columns/operations/drop.py 100.00% <100.00%> (ø)
mathesar/api/db/viewsets/columns.py 91.20% <100.00%> (ø)
mathesar/models.py 96.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4b5e4...6e8f695. Read the comment docs.

@silentninja silentninja merged commit 32e0bfd into master Mar 3, 2022
@silentninja silentninja deleted the mathesar-993-attnum-column-drop branch March 3, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Column dropping operation should use attnum
3 participants