-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split datetime into three UI types #1093
Merged
Merged
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c9ff1d1
Split UI datetime type
dmos62 8b7fe63
Add appropriate hints to time-related types
dmos62 c4dcaf4
Split datetime display options
dmos62 b0e5b07
Update hints
dmos62 57852ad
Merge branch 'add-filters-for-money-and-boolean' into split-datetime-…
dmos62 f677487
Merge branch 'time-filter-aliases' into split-datetime-into-three-ui-…
dmos62 1519e6b
Finish adapting serializers
dmos62 3cc27eb
Revert diplay_options changes; reduce validation to checking length
dmos62 a69ec81
Merge branch 'master' into split-datetime-into-three-ui-types
dmos62 27f75ca
Switch to defacto way to specify max_length
dmos62 d94580f
Merge branch 'master' into split-datetime-into-three-ui-types
dmos62 a3ed178
Merge branch 'master' into split-datetime-into-three-ui-types
silentninja ea6050a
Remove custom time/duration format validation
dmos62 7918971
Remove arrow library
dmos62 890064a
Merge branch 'split-datetime-into-three-ui-types' of github.com:cente…
dmos62 837550f
Merge branch 'master' into split-datetime-into-three-ui-types
dmos62 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our conclusion, other than a character length check, we don't need any additional validators. So the
validators
field and the validation function should be removed