-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace column index usage in db create operations with column attnum. #1110
Conversation
Pass correct table oid in `alter_column`
Codecov Report
@@ Coverage Diff @@
## mathesar-993-attnum-column-drop #1110 +/- ##
===================================================================
- Coverage 92.84% 92.79% -0.05%
===================================================================
Files 112 112
Lines 4037 4052 +15
===================================================================
+ Hits 3748 3760 +12
- Misses 289 292 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…mns.py:source_column` queryset parameter
@seancolsen SInce you are working on #1047, will you be able to fix these changes too? I can extract the breaking changes to a different PR if it will take time to fix on the frontend so as to not block other parts of the PR. |
@silentninja the front end doesn't yet have any functionality to duplicate columns and it doesn't make use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, please fix merge conflicts and merge.
…tions` to use table instance instead of a fixture when calling `mathesar.tests.api.test_column_api._get_columns_by_name`
Fixes #995
Breaking Change
id
instead of columnindex
. Sosource_column
field in the request body of POST method of/column/
accepts columnid
instead of columnindex
Other Changes
Column index usage has been completely removed from column
create
operations and from certain columnalter
operations as they were being used bycreate
operations.get_columns_name_from_attnums
returns a list of columnattnums
instead of a tuple of a row tuple with single attnum attributeget_column_name_from_attnum
convenience function has been introduced to help with fetching attnum for single column from column nameChecklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin