-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uppercase db types in db types endpoint #1176
Conversation
@dmos62 can you verify that spacing/underscore usage for multi-word types is also consistent? the type representation has to be identical wherever it shows up in the API. |
Also, I assume you'll make a new issue for the technical debt root cause to be handled at a later date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The related issue #1036 is for the root cause. I presume that it won't be closed by this PR automatically (since I replaced 'fixed' with 'related'). Edit: yep, 'related' shouldn't close the issue: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
I've not managed to find any inconsistencies. All places I thought to check use spaces in multi-word ids. |
Related #1036
Uppercases the DB type names in the
db/v0/databases/1/types
endpoint. That way, casing matches with the rest of our API.Technical details
Initially, the idea in #1036 was to find the root cause of the inconsistent casing in our code, but casing presumptions turned out more ingrained than first thought. Retreated to just uppercasing the endpoint's output, so as to conform with current policy to avoid doing technical debt work where possible.
Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin