-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus state being reset Fixes #1040 #1212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
=======================================
Coverage 93.39% 93.39%
=======================================
Files 113 113
Lines 4332 4332
=======================================
Hits 4046 4046
Misses 286 286
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@priyang12 Thanks for the PR! I have a comment, upon resolution of which we could merge this PR in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@priyang12 Looks good to me.
I added a small commit which changes the scope of the pagebutton: cd6dcce. It was not essential to keep it at the component level.
Fixes #1040
Technical details
Fixed Focus reset by adding data-page attribute in the button elements in pagination and grabbing the button in
afterUpdate()
method and manually putting the focus on the element.Screenshots
Screen.Recording.2022-03-22.at.1.58.00.PM.mov
I have changed the focus color to red for better visualization but in PR I changed back to the original.
Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin