Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus state being reset Fixes #1040 #1212

Merged
merged 5 commits into from
Mar 22, 2022

Conversation

priyang12
Copy link
Contributor

@priyang12 priyang12 commented Mar 22, 2022

Fixes #1040

Technical details

Fixed Focus reset by adding data-page attribute in the button elements in pagination and grabbing the button in afterUpdate() method and manually putting the focus on the element.

Screenshots

Screen.Recording.2022-03-22.at.1.58.00.PM.mov

I have changed the focus color to red for better visualization but in PR I changed back to the original.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@priyang12 priyang12 requested review from a team and pavish March 22, 2022 10:29
@pavish pavish self-assigned this Mar 22, 2022
@pavish pavish added the pr-status: review A PR awaiting review label Mar 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #1212 (6e6e7c0) into master (4be6ffe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1212   +/-   ##
=======================================
  Coverage   93.39%   93.39%           
=======================================
  Files         113      113           
  Lines        4332     4332           
=======================================
  Hits         4046     4046           
  Misses        286      286           
Flag Coverage Δ
pytest-backend 93.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be6ffe...6e6e7c0. Read the comment docs.

Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priyang12 Thanks for the PR! I have a comment, upon resolution of which we could merge this PR in.

@pavish pavish added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Mar 22, 2022
@pavish pavish assigned priyang12 and unassigned pavish Mar 22, 2022
@priyang12 priyang12 requested a review from pavish March 22, 2022 17:24
@pavish pavish enabled auto-merge March 22, 2022 18:17
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priyang12 Looks good to me.

I added a small commit which changes the scope of the pagebutton: cd6dcce. It was not essential to keep it at the component level.

@pavish pavish added pr-status: review A PR awaiting review and removed pr-status: revision A PR awaiting follow-up work from its author after review labels Mar 22, 2022
@pavish pavish assigned pavish and unassigned priyang12 Mar 22, 2022
@pavish pavish added status: done and removed pr-status: review A PR awaiting review labels Mar 22, 2022
@pavish pavish removed their assignment Mar 22, 2022
@pavish pavish merged commit 0269ad4 into mathesar-foundation:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Focus state being reset by browser in pagination component
3 participants