Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu to set cell to null #1215

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Add context menu to set cell to null #1215

merged 2 commits into from
Mar 25, 2022

Conversation

seancolsen
Copy link
Contributor

Fixes #930

Demo

Peek 2022-03-22 14-13

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen requested review from a team and pavish and removed request for a team March 22, 2022 18:20
@pavish pavish self-assigned this Mar 22, 2022
@pavish pavish added the pr-status: review A PR awaiting review label Mar 22, 2022
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seancolsen Looks good to me!

@pavish
Copy link
Member

pavish commented Mar 23, 2022

I'm not merging this since the base branch is context_menu for which I had a couple review comments. Once the base PR is merged, feel free to merge this into master.

@pavish pavish added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Mar 23, 2022
Base automatically changed from context_menu to master March 25, 2022 04:55
@pavish pavish enabled auto-merge March 25, 2022 07:43
@codecov-commenter
Copy link

Codecov Report

Merging #1215 (ab5b4ca) into master (b94bfa8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1215   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files         113      113           
  Lines        4341     4341           
=======================================
  Hits         4055     4055           
  Misses        286      286           
Flag Coverage Δ
pytest-backend 93.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94bfa8...ab5b4ca. Read the comment docs.

@pavish pavish merged commit 444d1e6 into master Mar 25, 2022
@pavish pavish deleted the 930_set_null branch March 25, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add context menu to set cell value to NULL
3 participants