Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record sorting #300

Merged
merged 14 commits into from
Jul 2, 2021
Merged

Record sorting #300

merged 14 commits into from
Jul 2, 2021

Conversation

eito-fis
Copy link
Contributor

@eito-fis eito-fis commented Jun 29, 2021

Fixes #158

Adds the option to sort the values returned from the record list endpoint.

Technical details
Modifies records.get_records() to use our fork of sqlalchemy_filters for sorting, and adds handling for the order_by url parameter to the record list endpoint.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@eito-fis eito-fis force-pushed the record_sorting branch 2 times, most recently from 2316a0d to 5999e0a Compare June 30, 2021 05:00
@eito-fis eito-fis marked this pull request as ready for review June 30, 2021 05:04
@eito-fis eito-fis requested review from a team, kgodey and pavish and removed request for a team June 30, 2021 05:04
@eito-fis
Copy link
Contributor Author

This should be reviewed after #299 is merged.

@eito-fis eito-fis force-pushed the record_sorting branch 2 times, most recently from 26f2c8b to 50d50e5 Compare June 30, 2021 23:41
Copy link
Contributor

@kgodey kgodey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, I'll also leave it to @mathemancer to review once #299 is reviewed.

@eito-fis eito-fis mentioned this pull request Jul 1, 2021
7 tasks
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

Base automatically changed from record_filtering to master July 2, 2021 19:37
@eito-fis eito-fis merged commit a9d7f3b into master Jul 2, 2021
@eito-fis eito-fis deleted the record_sorting branch July 2, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Allow sorting in record list API
3 participants