-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record sorting #300
Record sorting #300
Conversation
2316a0d
to
5999e0a
Compare
This should be reviewed after #299 is merged. |
26f2c8b
to
50d50e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me, I'll also leave it to @mathemancer to review once #299 is reviewed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good.
Fixes #158
Adds the option to sort the values returned from the record list endpoint.
Technical details
Modifies
records.get_records()
to use our fork of sqlalchemy_filters for sorting, and adds handling for theorder_by
url parameter to the record list endpoint.Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin