Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use schemas RPC APIs in the front end on the database page #3648

Open
wants to merge 2 commits into
base: rpc_frontend
Choose a base branch
from

Conversation

seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Jul 1, 2024

Notes

This PR implements the front end side of our RPC refactor for the following REST endpoints:

Endpoint HTTP Method Function
/api/db/v0/schemas/{schemaId}/ DELETE schemas.delete
/api/db/v0/schemas/{schemaId}/ PATCH schemas.patch
/api/db/v0/schemas/ GET schemas.list
/api/db/v0/schemas/ POST schemas.add

Working functionality

  • Everything on the database page including listing schemas, adding schemas, editing schemas, and deleting schemas

Notable user-facing changes

  • Exploration counts are removed from each schema card

    Before After
    image image

    We discussed this previously and made this choice in order to simplify implementation.

Broken functionality

Basically every other page of Mathesar is broken except for the root page which shows connections.

For example, the schema page looks like this:

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen added this to the Beta milestone Jul 1, 2024
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Jul 1, 2024
@seancolsen
Copy link
Contributor Author

Heads up that I just realized that common_data is still broken here. The schemas load when the page is loaded client-side, but not when it's loaded fully from the server. I think I'd like to handle that in a separate PR.

@seancolsen
Copy link
Contributor Author

Thanks @Anish9901, that works.

@seancolsen seancolsen changed the title Use schemas RPC APIs in the front end Use schemas RPC APIs in the front end on the database page Jul 3, 2024
@seancolsen seancolsen removed the pr-status: review A PR awaiting review label Jul 3, 2024
@seancolsen seancolsen marked this pull request as draft July 3, 2024 13:33
@seancolsen
Copy link
Contributor Author

Marking as a draft because I realized that some more changes are needed to the front end data structures.

@seancolsen
Copy link
Contributor Author

Sorry — never mind. After some additional digging, I the problem I though I had identified was not actually there.

Ready for review now.

@seancolsen seancolsen marked this pull request as ready for review July 3, 2024 13:40
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants