-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import preview page #561
Import preview page #561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavish This looks good to me, but all columns are still showing up as VARCHAR
instead of the inferred type. It doesn't look like you're looking at the type_suggestions
endpoint for the table to get the appropriate types for the preview. I don't know if we actually documented that endpoint anywhere, sorry about that.
Do you want to fix that in this PR or a future PR?
@pavish Okay, thanks. I'll create a separate issue for that and merge this PR. |
I made #568 for the type suggestions work. |
Related to #295
Fixes #296
Fixes #548
Fixes #524
This PR has:
Note:
Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin