Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import preview page #561

Merged
merged 14 commits into from
Aug 16, 2021
Merged

Import preview page #561

merged 14 commits into from
Aug 16, 2021

Conversation

pavish
Copy link
Member

@pavish pavish commented Aug 15, 2021

Related to #295
Fixes #296
Fixes #548
Fixes #524

This PR has:

  • Refactoring of stores and pages to be schema centric, instead of db
  • Preview page for file import
  • Import status indicator
  • Switches open tables when moving to other schemas/db

Note:

  • This PR has all the UI changes needed for the preview page, but there are issues/changes needed with some backend apis.
  • This leads to some features not working due to 500s from api calls.
    • Changing column names/types is not working for both:
      • Tried with tables PATCH, as mentioned on import wiki
      • Tried with columns API PATCH (Which is currently used)
    • Updating import_verified is not allowed (Not done at the moment)
  • Does not focus much on styling. It will be done incrementally with future PRs.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link
Contributor

@kgodey kgodey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavish This looks good to me, but all columns are still showing up as VARCHAR instead of the inferred type. It doesn't look like you're looking at the type_suggestions endpoint for the table to get the appropriate types for the preview. I don't know if we actually documented that endpoint anywhere, sorry about that.

Do you want to fix that in this PR or a future PR?

@pavish
Copy link
Member Author

pavish commented Aug 16, 2021

@kgodey I was not aware of the type_suggestions endpoint. I've marked this PR as related to #295, and not as fixes.
We could create a separate issue for the type_suggestions and I'll pick that up.

@kgodey
Copy link
Contributor

kgodey commented Aug 16, 2021

@pavish Okay, thanks. I'll create a separate issue for that and merge this PR.

@kgodey
Copy link
Contributor

kgodey commented Aug 16, 2021

I made #568 for the type suggestions work.

@kgodey kgodey merged commit 3fa827a into master Aug 16, 2021
@kgodey kgodey deleted the import_preview branch August 16, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2 participants