-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: The line width argument adding request for 'candlestick_ohlc' about the 'Wick/shadow' part(above/blow line) #657
Comments
@Mitchell-kw-Lee Please take a look at the "widths" documentation for the new mplfinance api. Let me know if that allows you to do what you want. Alternatively propose the enhancement to apply to the new api. Please note that |
@DanielGoldfarb .First of all, thanks for your guide.
It shows below that has an issue. The figure show the wick bolder than original 1pixel line. But It also enlarge candle body's border as well. |
@Mitchell-kw-Lee However this could be a somewhat easy change to mplfinance to have two separate width parameters. Inside the We would have to take some care to be backwards compatible for those users who are already specifying Alternatively we could create a new What do you think? |
@DanielGoldfarb Thanks for the reply. By quick reading all of those are seems reasonable(I know you are the guru on this). |
@DanielGoldfarb Please don't miss the feature that setting color for 'wick_linewidth' as candle border color. |
@Mitchell-kw-Lee |
@Mitchell-kw-Lee |
@DanielGoldfarb I have no idea how to proceed it. If you want, let's do this quick.
|
@Mitchell-kw-Lee Sorry for the delayed reply. Please see https://github.com/matplotlib/mplfinance/blob/master/CONTRIBUTING.md#fork-clone-workflow and comments at the bottom there about coding standards. Please take a shot at modifying the code according to my suggestions here and the above contributing guidelines. If you have any specific questions feel free to ask. I recommend that once you have a clone on your local machine, assuming you are the only user on that machine, install mplfinance with If you do share a machine with others (who also may be using mplfinance) then do the same as above but in a python virtual environnment so that only you see the version you are working on. Let me know if you have any questions. Thanks. --Daniel |
Is your feature request related to a problem? Please describe.
Not a problem related. But new request.
Describe the solution you'd like
![image](https://private-user-images.githubusercontent.com/42901596/296632813-d943b4e1-0d7e-4b0f-87ed-2a963e7751ae.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwMDcxMzUsIm5iZiI6MTcyNjAwNjgzNSwicGF0aCI6Ii80MjkwMTU5Ni8yOTY2MzI4MTMtZDk0M2I0ZTEtMGQ3ZS00YjBmLTg3ZWQtMmE5NjNlNzc1MWFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDIyMjAzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwYzBkN2Y0MjM1NzkwZGQzYTQ4MGIwYWJiYjY2OWRmZTk1ZTEzZWE4OWViZGIzMGRjNzQ2MTQ0MDU5YTQwODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sFyTloK0bkKbIZUUjiby0qj46W-ttO6K6qAFQUaf1Rk)
![image](https://private-user-images.githubusercontent.com/42901596/296633121-2d73e8d7-d6b6-461a-8c9e-28915a3fa0a8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwMDcxMzUsIm5iZiI6MTcyNjAwNjgzNSwicGF0aCI6Ii80MjkwMTU5Ni8yOTY2MzMxMjEtMmQ3M2U4ZDctZDZiNi00NjFhLThjOWUtMjg5MTVhM2ZhMGE4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDIyMjAzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFmMDdlNjllYWM4NTljYmFiZGUwYjYzNzQyYjkxZmI2MTRmYTE4N2YwMTE3MWM5YzcwNTU5ZDNjYmNlMzEyZGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.8B_KQfXBOYvZ8QbVGYTqWGw03HwT_Aw7iqS0DclHqrM)
Now we only can draw
We want to draw this as we want
Describe alternatives you've considered
I have edit the source file 'original_flavor.py' > the function '_candlestick' > manually edit the line width value within 'vline = Line2D(xx HERE xxx)' from '1' to 'what I want'
Additional context
What if we can control the width by ratio or absolute number from any kind of argument style that flexible.
Please.
The text was updated successfully, but these errors were encountered: