-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volume_mco
api for volume custom colors
#611
base: master
Are you sure you want to change the base?
Conversation
solves #320 |
The code looks good, and I've tested on my and seems to work ok. I'm just trying to think through a few things to decide whether or not to make some changes. First I'm trying to remember why I wrote There is also the issue of what I wrote at the bottom of the marketcolor_overrides notebook indicating that my intention for overriding volume colors was to only override volume colors when the override was a "marketcolor object" (the dict that is returned from Comparing your implementation with this idea that I had posted at the bottom of the notebook, there are pros and cons to each: You implementation allows the volume overrides to be either a color-like object, or a marketcolor object. But it does not allow separate overrides for volume and candles. On the other hand, using only marketcolor objects to override volume (which would not require a separate @alexpvpmindustry let me know if you have any thoughts on this. Presently I am leaning towards your implementation because it is simpler (both as an implementation, and for a user to use). On the other hand, it would be nice, at some point in time, to deprecate If you have an opinion on all of this, I am interested to hear it. And if not, that is fine too. Part of the reason for me writing this is just to have a record of my thoughts (which I probably should have written when I first implemented the overrides). I have no problem deciding to just merg this implementation, and worry about deprecating |
hello! hope u r doing well! |
oh i was looking for this feature :( |
new feature: add
volume_mco
such that it follows the mco colorscheme inmarketcolor_overwrite
usage:
note:
marketcolor_overwrite
inputsmarketcolor_overwrite
must be validmarketcolor_overwrite
isNone