Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vcedge to make_marketcolors() #670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kootsZhin
Copy link

Not sure if it was intended but currently vcedge which sets the edge colors for volume bars is missing from make_marketcolors() and as a results, the results with inherent=True is different from the example notebook.

Example

The below example replicate the notebook example with the same usage code.

mc = mpf.make_marketcolors(up='#00ff00',down='#ff00ff',inherit=True)

s = mpf.make_mpf_style(base_mpf_style="nightclouds", y_on_right=True, marketcolors=mc)

mpf.plot(df, title=f"\n{symbol}", type='candle', volume=True, style=s, ylabel="", ylabel_lower="")

Before adding vcedge (currently)

fa6ef90e-948a-4819-a736-bacc150369a9

After adding vcedge

0992f6c4-99a5-4866-bb80-6158c7d58d9b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant