Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NO_COLOR (https://no-color.org). #43

Merged
merged 1 commit into from
May 16, 2022
Merged

Support NO_COLOR (https://no-color.org). #43

merged 1 commit into from
May 16, 2022

Conversation

AlekSi
Copy link
Contributor

@AlekSi AlekSi commented Jul 23, 2021

Also, handle IS_NO_COLOR=1 and IS_NO_COLOR=FALSE.

@matryer
Copy link
Owner

matryer commented Sep 14, 2021

@AlekSi thanks for this - shall we remove mention of IS_NO_COLOR (while still supporting it) at the same time?

@AlekSi
Copy link
Contributor Author

AlekSi commented Dec 14, 2021

I don't know :)

@matryer
Copy link
Owner

matryer commented Dec 14, 2021

@AlekSi let's :) Would you be able to add it to your PR?

@AlekSi
Support NO_COLOR (https://no-color.org).
1fd8679 
Also, handle `IS_NO_COLOR=1` and `IS_NO_COLOR=FALSE`.
@AlekSi
Copy link
Contributor Author

AlekSi commented Dec 14, 2021

PTAL

matryer
matryer approved these changes May 16, 2022
View reviewed changes
Copy link
Owner

@matryer matryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you

@matryer matryer merged commit 02e4121 into matryer:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matryer matryer matryer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlekSi @matryer