Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Marko #149

Merged
merged 12 commits into from
Apr 3, 2023
Merged

Add Marko #149

merged 12 commits into from
Apr 3, 2023

Conversation

tigt
Copy link
Contributor

@tigt tigt commented Jan 31, 2023

  • Depends on Tweak some samples for clarity and better behavior in playgrounds #148 to be consistent with other frameworks — I have no problems editing them back if that doesn’t get merged, however
  • Places Marko with the other resumable frameworks (if there’s other logic for how the frameworks are sorted, I’d love to know)
  • Updated the contribution guidelines with what I had to figure out to get the Playground URL working
  • Some of the Marko playground URLs produce interesting errors — those are bugs on our end, we’ll fix them out of band

@tigt
Copy link
Contributor Author

tigt commented Jan 31, 2023

Oh, uh, I’d be happy to fix up my WIP commit history if your repo doesn’t squash upon merge

@matschik
Copy link
Owner

matschik commented Feb 9, 2023

Thanks a lot ! Hope we can find a solution to #148 PR, then I'll review it

@matschik
Copy link
Owner

If you can submit this PR without playground issues, we'll be able to add Marko.

@tigt
Copy link
Contributor Author

tigt commented Feb 17, 2023

Roger. Might be a little bit before I get that update in — just left eBay

@tigt
Copy link
Contributor Author

tigt commented Apr 3, 2023

Okay, I changed the Viewport Size and mixed checkbox examples back to Page Title and autofocused input.

@matschik matschik merged commit a01e903 into matschik:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants