Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Polaron dispersion functionality #74

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Chiffafox
Copy link
Collaborator

@Chiffafox Chiffafox commented Mar 10, 2023

This pull request (re-)introduces polaron tracking functionality into the codebase. It is available for all Solver types, at both zero and finite T. Tests are also included. The "scipy fit" method is used for the fit.

Also added are the processing of dispersion function results, and an effective mass fit (untested).

Have not yet tested "black" and other simple checks and still missing some tests, and no documentation yet -- hence the WIP tag.

@Chiffafox Chiffafox self-assigned this Mar 10, 2023
@matthewcarbone
Copy link
Owner

@Chiffafox this is really great, thank you. My two main concerns are:

  • Checks are failing 😁
  • There seems to be a ton of repetition between base.py and solvers.py. I didn't do a diff check to see just how much but I can't imagine we can't somehow golf this down a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants