Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: angular-ivy-compliant refactoring #376

Merged
merged 1 commit into from
Jul 27, 2023
Merged

feat: angular-ivy-compliant refactoring #376

merged 1 commit into from
Jul 27, 2023

Conversation

maximelafarie
Copy link
Owner

@maximelafarie maximelafarie commented Jul 19, 2023 •
edited
Loading

TASKS:

  • Make the lib angular-ivy-compliant
  • Make the test pass
  • Remove commented test blocks
  • Update readme
  • Add Github Actions routines (at least for lint and tests)
  • Remove / update all previous CI routines links (travis, codacy, etc.)

NOT MANDATORY TASKS:

  • Add package publish automation (with Github Actions)
  • Update the demo (with Angular 16)
  • Add external documentation (with Docusaurus)
  • Project cleanup (remove uselessly nested folders, etc.)
  • Update changelog

@maximelafarie maximelafarie mentioned this pull request Jul 19, 2023
Closed
@khylias khylias added the Work In Progress This is a Work In Progress (WIP) label Jul 19, 2023
@maximelafarie maximelafarie force-pushed the feature/v14 branch 2 times, most recently from b6496a4 to 41b33ae Compare July 19, 2023 15:35
@maximelafarie maximelafarie mentioned this pull request Jul 19, 2023
Closed
@maximelafarie maximelafarie force-pushed the feature/v14 branch 2 times, most recently from 690bac4 to 511b37b Compare July 26, 2023 23:50
@maximelafarie maximelafarie self-assigned this Jul 26, 2023
@maximelafarie maximelafarie removed the Work In Progress This is a Work In Progress (WIP) label Jul 26, 2023
@maximelafarie
Copy link
Owner Author

Thank you @khylias for keeping an eye on this! 🙏
I've done an implementation test here and will merge this branch as 14.0.2 has been released on npm. I won't require someone to full review this as the whole code has been refactored and it may take a lot of time.
However, I could use some help with feedback on version 14!

@maximelafarie maximelafarie merged commit ada1ca5 into master Jul 27, 2023
2 checks passed
@maximelafarie maximelafarie mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maximelafarie maximelafarie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Angular 16 (Ivy compatibility without ngcc) 🔥 NEWS, INFO AND FUTURE OF NGXSM 🚨
2 participants
@maximelafarie @khylias