Fix/issue 379 #380
Merged
Fix/issue 379 #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsen-amani
approved these changes
Nov 4, 2023
maximelafarie
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
LGTM. Thank you very much @AntLer-24rus for your work and the kind words. You did a great job, I will push a release today!
|
Also thank you @mohsen-amani for pre-approving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maximelafarie, hello!
I think I have solved the problem described in issued #379. In the test environment, at first glance, everything works correctly. The angular version was also raised to 16 and the expectations in the tests were slightly added. This library is very important to me, two large projects depend on it and I would not like to switch to something else.
If possible, I ask you to conduct a review and include changes in the production build. Thank you in advance!
close #379