🐛 clean code

bouncer.go

@@ -59,7 +59,6 @@ type Bouncer struct {
 	crowdsecScenarios      []string
 	updateInterval         int64
 	defaultDecisionTimeout int64
-	CrowdsecStreamTimeout  int64
 	customHeader           string
 	crowdsecStreamRoute    string
 	crowdsecHeader         string
@@ -84,14 +83,6 @@ func New(ctx context.Context, next http.Handler, config *configuration.Config, n
 	var tlsConfig *tls.Config
 	crowdsecStreamRoute := ""
 	crowdsecHeader := ""
-	// here we have GetVariable which returns a string
-	crowdsecStreamTimeoutStr, _ := configuration.GetVariable(config, "CrowdsecStreamTimeout")
-	// I would had a test that the value can be converted to int
-	_, err = fmt.Sscan(crowdsecStreamTimeoutStr, &config.CrowdsecStreamTimeout)
-	if err != nil {
-		logger.Error(fmt.Sprintf("New:sscan: %s", err.Error()))
-		return nil, err
-	}
 	if config.CrowdsecMode == configuration.AloneMode {
 		config.CrowdsecCapiMachineID, _ = configuration.GetVariable(config, "CrowdsecCapiMachineID")
 		config.CrowdsecCapiPassword, _ = configuration.GetVariable(config, "CrowdsecCapiPassword")

pkg/configuration/configuration.go

@@ -48,7 +48,6 @@ type Config struct {
 	CrowdsecCapiPassword                     string   `json:"crowdsecCapiPassword,omitempty"`
 	CrowdsecCapiPasswordFile                 string   `json:"crowdsecCapiPasswordFile,omitempty"`
 	CrowdsecCapiScenarios                    []string `json:"crowdsecCapiScenarios,omitempty"`
-	CrowdsecStreamTimeout                    int64    `json:"crowdsecStreamTimeout,omitempty"`
 	UpdateIntervalSeconds                    int64    `json:"updateIntervalSeconds,omitempty"`
 	DefaultDecisionSeconds                   int64    `json:"defaultDecisionSeconds,omitempty"`
 	DefaultTimeoutSeconds                    int64    `json:"defaultTimeoutSeconds,omitempty"`
@@ -81,7 +80,6 @@ func New() *Config {
 		CrowdsecLapiHost:              "crowdsec:8080",
 		CrowdsecLapiKey:               "",
 		CrowdsecLapiTLSInsecureVerify: false,
-		CrowdsecStreamTimeout:         10,
 		UpdateIntervalSeconds:         60,
 		DefaultDecisionSeconds:        60,
 		DefaultTimeoutSeconds:         10,