Update automod.py #77
Conversation
Fixed AutoModTriggerMetadata.to_dict() because if you only provided regex_patterns it would return None. Now it doesnt. Signed-off-by: LukeZ <[email protected]>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Failed to review pull request #77 due to the following error:
<class 'KeyError'>: 0
Try re-running the review or contact [email protected] for help.
There was a problem hiding this comment.
PR Type: Bug fix
PR Summary: The pull request updates the to_dict method in automod.py to ensure that it returns a dictionary with regex_patterns even when keyword_filter is not provided. This change addresses a specific issue where the method would return None if only regex_patterns were provided, which is now fixed.
Decision: Comment
📝 Type: 'Bug fix' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure comprehensive testing around the
to_dictmethod to verify that it behaves as expected with various combinations ofkeyword_filterand_regex_patterns. - Consider adding more detailed documentation or comments in the code explaining the importance of this change for future maintainability.
- Review other parts of the codebase that interact with the output of
to_dictto ensure they correctly handle the scenarios wherekeyword_filtermight be empty orNone.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Fixed AutoModTriggerMetadata.to_dict() because if you only provided regex_patterns it would return None. Now it doesnt.