This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Threaded is now Tasked #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run ReSharper Code Cleanup Run Optimize References Close All Sensible ReSharper Issues
Implements loop canceling with timeout abort fallback Remove all EventHandlers! Set StartupObject Fix bug in OnUIAutomationEvent by casting to list
Make all threads in to tasks Implement Cancelation Token Convert foreach to Parallel.ForEach
for clarity
|
Appreciate your contributions here. My experience with C# is limited so these changes have been very helpful and educational |
|
Hi, sorry to ask here, but is the issue tab disabled for this repo on purpose? I just wanted to ask whether it would be possible to programmatically disable the grouping of taskbar buttons, beyond what MS Windows proposes (they are still grouped even when you select "never" in taskbar properties, just not merged). |
|
Not possible with this script. You can movie the taskbar group as a whole but cannot manipulate individual icons without causing explorer to glitch and reload the UI.
…Sent from my iPhone
On May 21, 2020, at 6:54 AM, Amyn ***@***.***> wrote:
Hi, sorry to ask here, but is the issue tab disabled for this repo on purpose? I just wanted to ask whether it would be possible to programmatically disable the grouping of taskbar buttons, beyond what MS Windows proposes (they are still grouped even when you select "never" in taskbar properties, just not merged).
My ultimate goal is to reorder the taskbar windows in most recently used order.
Thanks.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@amynbe brings a good question. Did @mdhiggins disable Issues on purpose? https://help.github.com/en/github/managing-your-work-on-github/disabling-issues |
|
Fixed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used ReSharper to implement some best practice recommendations. Then I implemented the Task pattern because modern recommendation is to never manually create Threads. The task handler decides how to run stuff on the threadpool. This should allow us to run our tasks in parallel. On a multi-monitor setup with many taskbars you should see all the icons moving together at the same time. Tasks also come with a CancellationToken feature made to handle the Thread.Abort situation gracefully. All tasks can cancel at the same time because they all share the token. This is more threadsafe than the boolean cancel flag I was using.