Remove bitstring dependency #59
Conversation
|
Looks like there are some issues with the tests hanging around still. Some of the integration tests for CSV parsing we will either need to remove entirely or we will need to come up with an XTCE definition for the previously used CSV files. |
greglucas
force-pushed
the
rm-bitstring-dependency
branch
from
caba4cd
to
4304d7e
Compare
For some reason, I thought the csv parsing required bitstring which is why I removed it earlier. It turns out it doesn't, so I've now reverted all of the CSV changes and made this just a removal of bitstring now. This is much cleaner and can take place in two steps with a future removal of the legacy csv parser. |
This removes the bitstring dependency and all bitstring inputs allowed with it. You can pass in the raw objects instead of the bitstring objects now. All internal bookkeeping is done with a PacketData class that is just a thin wrapper around bytes data to keep track of the amount of data read.
greglucas
force-pushed
the
rm-bitstring-dependency
branch
from
4304d7e
to
34b0f5b
Compare
Title of PR
This removes the bitstring dependency and all bitstring inputs allowed with it. You can pass in the raw objects instead of the bitstring objects now.
This also removes thelegacy_parsermethod which was kept around to support csv parsing. This has been removed in favor of converting the csv packet definitions into the XTCE format instead.This sits on top of #58 so there wasn't as much thrashing going on. Only the second commit is the removal portion.
NOTE: I have removed the entire csvdef module. I am not sure if you want to keep that around or not. This is definitely the heavy-handed approach of just removing all of the legacy things and moving on in a major version bump.Checklist