Fixed strcasestr()

meetecho · Sep 25, 2022 · 933a137 · 933a137
1 parent 46364c6
commit 933a137
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/src/sdp.c b/src/sdp.c
@@ -161,17 +161,17 @@ int janus_sdp_process_remote(void *ice_handle, janus_sdp *remote_sdp, gboolean r
 		if(a && a->name && a->value) {
 			if(!strcasecmp(a->name, "fingerprint")) {
 				JANUS_LOG(LOG_VERB, "[%"SCNu64"] Fingerprint (global) : %s\n", handle->handle_id, a->value);
-				if(strcasestr(a->value, "sha-256 ") == a->value) {
-					rhashing = g_strdup("sha-256");
-					rfingerprint = g_strdup(a->value + strlen("sha-256 "));
-				} else if(strcasestr(a->value, "sha-1 ") == a->value) {
-					JANUS_LOG(LOG_WARN, "[%"SCNu64"]  Hashing algorithm not the one we expected (sha-1 instead of sha-256), but that's ok\n", handle->handle_id);
-					rhashing = g_strdup("sha-1");
-					rfingerprint = g_strdup(a->value + strlen("sha-1 "));
-				} else {
-					/* FIXME We should handle this somehow anyway... OpenSSL supports them all */
-					JANUS_LOG(LOG_WARN, "[%"SCNu64"]  Hashing algorithm not the one we expected (sha-256/sha-1), *NOT* cool\n", handle->handle_id);
-				}
+                if(!strncasecmp(a->value, "sha-256", strlen("sha-256"))) {
+                    rhashing = g_strdup("sha-256");
+                    rfingerprint = g_strdup(a->value + strlen("sha-256 "));
+                } else if(!strncasecmp(a->value, "sha-1", strlen("sha-1"))) {
+                    JANUS_LOG(LOG_WARN, "[%"SCNu64"]  Hashing algorithm not the one we expected (sha-1 instead of sha-256), but that's ok\n", handle->handle_id);
+                    rhashing = g_strdup("sha-1");
+                    rfingerprint = g_strdup(a->value + strlen("sha-1 "));
+                } else {
+                    /* FIXME We should handle this somehow anyway... OpenSSL supports them all */
+                    JANUS_LOG(LOG_WARN, "[%"SCNu64"]  Hashing algorithm not the one we expected (sha-256/sha-1), *NOT* cool\n", handle->handle_id);
+                }
 			} else if(!strcasecmp(a->name, "ice-ufrag")) {
 				JANUS_LOG(LOG_VERB, "[%"SCNu64"] ICE ufrag (global):   %s\n", handle->handle_id, a->value);
 				ruser = g_strdup(a->value);