-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
2 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad326e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmatth just FYI, since from my understanding you're the mantainer of libspeex-dsp, do you think it may be worthwhile to address this fix as part of the libspeex-dsp codebase?
Just to give you some context, we noticed leaks under some circumstances, and found out they were caused by
jitter_buffer_put
. The function would in some cases not queue the packet in the buffer, but since the function is avoid
, there would be no way for the application to know that happened, causing the allocated buffer never to be freed. I noticed this fix in one of the library forks (xpilot-project/speexdsp@36e68e3) which is what led me to externalise the same check in the AudioBridge plugin in order to know when to free the packet.Not sure if that fork includes other fixes, but this one does indeed look like a bug that should be fixed. In case you think it makes sense, I guess a version bump (minver?) would be needed too, just so that we (and others) can version check whether they need to externalise the check to free data in that case or not.